forked from opensearch-project/security-dashboards-plugin
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed the tenant switching after timeout (opensearch-project#1090)
Signed-off-by: Ryan Liang <[email protected]>
- Loading branch information
Showing
3 changed files
with
93 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
/* | ||
* Copyright OpenSearch Contributors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
import { interceptError } from '../../../utils/logout-utils'; | ||
import { setShouldShowTenantPopup } from '../../../utils/storage-utils'; | ||
import { LOGIN_PAGE_URI } from '../../../../common'; | ||
|
||
jest.mock('../../../utils/storage-utils', () => ({ | ||
setShouldShowTenantPopup: jest.fn(), | ||
})); | ||
|
||
describe('Intercept error handler', () => { | ||
const fakeError401 = { | ||
response: { | ||
status: 401, | ||
}, | ||
}; | ||
|
||
const fakeError400 = { | ||
response: { | ||
status: 400, | ||
}, | ||
}; | ||
|
||
it('Intercept error handler Should call setShouldShowTenantPopup on session timeout', () => { | ||
const sessionTimeoutFn = interceptError(LOGIN_PAGE_URI, window); | ||
sessionTimeoutFn(fakeError401, null); | ||
expect(setShouldShowTenantPopup).toBeCalledTimes(1); | ||
}); | ||
|
||
it('Intercept error handler Should not call setShouldShowTenantPopup on session timeout', () => { | ||
const sessionTimeoutFn = interceptError(LOGIN_PAGE_URI, window); | ||
sessionTimeoutFn(fakeError400, null); | ||
expect(setShouldShowTenantPopup).toBeCalledTimes(0); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/* | ||
* Copyright OpenSearch Contributors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
import { setShouldShowTenantPopup } from './storage-utils'; | ||
import { | ||
HttpInterceptorResponseError, | ||
IHttpInterceptController, | ||
} from '../../../../src/core/public'; | ||
import { CUSTOM_ERROR_PAGE_URI, LOGIN_PAGE_URI } from '../../common'; | ||
|
||
export function interceptError(logoutUrl: string, thisWindow: Window): any { | ||
return (httpErrorResponse: HttpInterceptorResponseError, _: IHttpInterceptController) => { | ||
if (httpErrorResponse.response?.status === 401) { | ||
setShouldShowTenantPopup(null); | ||
if ( | ||
!( | ||
thisWindow.location.pathname.toLowerCase().includes(LOGIN_PAGE_URI) || | ||
thisWindow.location.pathname.toLowerCase().includes(CUSTOM_ERROR_PAGE_URI) | ||
) | ||
) { | ||
if (logoutUrl) { | ||
thisWindow.location.href = logoutUrl; | ||
} else { | ||
// when session timed out, user credentials in cookie are wiped out | ||
// refres the page will direct the user to go through login process | ||
thisWindow.location.reload(); | ||
} | ||
} | ||
} | ||
}; | ||
} |