Fixes tests for vis type persistence change (opensearch-project#600) (o…

…pensearch-project#601) Signed-off-by: Ashwin Pc <[email protected]> (cherry picked from commit 13d3e2d) Co-authored-by: Ashwin P Chandran <[email protected]> Signed-off-by: [email protected] <[email protected]>
leanneeliatra · Sep 15, 2023 · 11bb757 · 11bb757
1 parent c1bca3a
commit 11bb757
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/...ation/core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/dashboard.spec.js b/...ation/core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/dashboard.spec.js
@@ -56,9 +56,10 @@ if (Cypress.env('VISBUILDER_ENABLED')) {
       // Add Vis Builder Visualisation to dashboard
       cy.getElementByTestId('dashboardEditMode').click();
       cy.getElementByTestId('dashboardAddPanelButton').click();
-      cy.getElementByTestId('savedObjectFinderSearchInput').type(
-        `${VB_LINE_VIS_TITLE}{enter}`
-      );
+      cy.getElementByTestId('savedObjectFinderFilterButton').click();
+      cy.getElementByTestId(
+        'savedObjectFinderFilter-visualization-visbuilder'
+      ).click();
       cy.getElementByTestId(
         `savedObjectTitle${toTestId(VB_LINE_VIS_TITLE)}`
       ).click();

diff --git a/cypress/utils/dashboards/vis_builder/commands.js b/cypress/utils/dashboards/vis_builder/commands.js
@@ -21,7 +21,7 @@ Cypress.Commands.add('vbSelectDataSource', (dataSource) => {
     .click(opts);
 });
 
-Cypress.Commands.add('vbSelectVisType', (type) => {
+Cypress.Commands.add('vbSelectVisType', (type, confirm = false) => {
   const opts = { log: false };
 
   Cypress.log({
@@ -32,7 +32,9 @@ Cypress.Commands.add('vbSelectVisType', (type) => {
 
   cy.getElementByTestId('chartPicker', opts).click(opts);
   cy.get('[data-test-subj^=visType-', opts).contains(type, opts).click(opts);
-  cy.getElementByTestId('confirmModalConfirmButton', opts).click(opts);
+  if (confirm) {
+    cy.getElementByTestId('confirmModalConfirmButton', opts).click(opts);
+  }
 });
 
 Cypress.Commands.add('vbEditAgg', (fields = []) => {

diff --git a/cypress/utils/dashboards/vis_builder/constants.js b/cypress/utils/dashboards/vis_builder/constants.js
@@ -5,7 +5,7 @@
 
 import { BASE_PATH } from '../../base_constants';
 
-export const VB_DEBOUNCE = 200; // Debounce time for VisBuilder fields in ms
+export const VB_DEBOUNCE = 300; // Debounce time for VisBuilder fields in ms
 
 export const VB_INDEX_DATA = 'vis-builder.data.txt';
 export const VB_INDEX_DOC_COUNT = '10,000';