fix: carousel autoplaying after swipe #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcuevacem
approved these changes
Aug 6, 2021
|
@dcuevacem @leandrowd I am also seeing this bug. Can we get an update on the PR and an ETA on when it will be merged/released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this finally, I think. This builds on the fix from @renancleyson-dev in PR #583 and @SUCHiDEV in PR #597 and as mentioned in Issue #621.
I think those fixes were correct, except we additionally need to move the
clearAutoPlaycall fromonSwipeStarttoonSwipeEnd.This fix is working flawlessly in my local environment and on an actual phone, not simulated. I can also toggle
autoPlayon and off and it behaves as expected in each instance.