BUGFIX - updates to arrow key navigation handler to work in IE/Edge. … #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Changed match from e.key => e.keyCode. Updated Carousel tests to account for new methods. There are two tests that fail, but they were failing in the existing repo as well.
|
Hey @jzeltman, which 2 tests are failing for you? I just tried and everything passes here. |
leandrowd
reviewed
Dec 1, 2017
src/components/Carousel.js
Outdated
| @@ -225,12 +225,12 @@ class Carousel extends Component { | |||
| const { axis } = this.props; | |||
| const isHorizontal = axis === 'horizontal'; | |||
|
|
|||
| const nextKey = isHorizontal ? 'ArrowRight' : 'ArrowDown'; | |||
| const prevKey = isHorizontal ? 'ArrowLeft' : 'ArrowUp'; | |||
| const nextKey = isHorizontal ? 39 : 40; | |||
There was a problem hiding this comment.
Could you create a map to identify these numbers with a readable name?
example:
const keyNames = {
ArrowRight: 39,
ArrowDown: 40
};
const nextKey = isHorizontal ? keyNames.ArrowRight : keyNames.ArrowDown;
leandrowd
reviewed
Dec 1, 2017
src/__tests__/Carousel.js
Outdated
|
|
||
| expect(componentInstance.increment.mock.calls.length).toBe(1); | ||
| expect(componentInstance.decrement.mock.calls.length).toBe(0); | ||
| }); | ||
|
|
||
| it('should call only decrement on ArrowUp', () => { | ||
| componentInstance.navigateWithKeyboard({key: 'ArrowUp'}); | ||
| it('should call only decrement on 38', () => { |
There was a problem hiding this comment.
Please, keep the tests descriptions as "should call only decrement on ArrowUp (38)"... Much easier to understand.
|
Thanks @jzeltman, it was published to npm as 3.1.30 |
|
This fixes #200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed match from e.key => e.keyCode. Updated Carousel tests to account for new methods.
There are two tests that fail, but they were failing in the existing repo as well.