#98: Fixing bug where the Thumbs component would throw an error if a custom component was rendered inside it #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…custom component was rendered inside it
|
I'm just not getting any thumbs if I use a component instead of a plain |
|
At this moment we only look for IMG tags to create the thumbs. You can render an image next to your custom component and it will work out you can disable thumbs. If you have a different suggestion, feel free to submit a PR. Thanks |
PradeepChada
pushed a commit
to PradeepChada/react-responsive-carousel
that referenced
this pull request
Dec 22, 2021
…435923/change-store-location 180435923 - Validation fix for store location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.