Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel Controls Hard to Reach for Keyboard Only Users #547

Closed
greenyouse opened this issue Jan 31, 2021 · 1 comment
Closed

Carousel Controls Hard to Reach for Keyboard Only Users #547

greenyouse opened this issue Jan 31, 2021 · 1 comment

Comments

@greenyouse
Copy link
Contributor

Problem:
The carousel slides currently come before the carousel controls in the DOM.

Impact:
This makes it harder for keyboard-only users to tab to the carousel controls. To get there they need to tab through all of the slide contents first which is more difficult.

Recommended Solution:
Move the carousel controls (.control-dots) above the slides (.slider-wrapper) in the DOM without affecting the current visual styles. Having the controls be slotted first will allow keyboard only users to tab into the carousel controls before getting to the slides.

greenyouse added a commit to greenyouse/react-responsive-carousel that referenced this issue Jan 31, 2021
leandrowd added a commit that referenced this issue Feb 1, 2021
 #547: Moving carousel controls for kbd users
@greenyouse
Copy link
Contributor Author

This part is looking good too with the latest changes on master. I'm going to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant