Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus given to non-interactive div #545

Closed
greenyouse opened this issue Jan 31, 2021 · 1 comment
Closed

Focus given to non-interactive div #545

greenyouse opened this issue Jan 31, 2021 · 1 comment
Labels

Comments

@greenyouse
Copy link
Contributor

greenyouse commented Jan 31, 2021

Hi, I noticed a few a11y issues with this project so I wanted to make a few issues to help out. I can try to follow up with some PRs today too. Thank you for all the work you've done building and maintaining this! It's a really nice project to use 😄

Problem:
.carousel-root has a tabindex=0 attribute
Focus should not be given to non-interactive elements in the DOM.

Impact:
Screen reader and keyboard only users will stop on this element but not be able to do anything with it since it's non-interactive.
Also nothing will be read to screen readers when they land on this element. That will likely be confusing since each element that is focusable needs to serve a purpose for screen reader users.
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex#accessibility_concerns

Recommended Solution:
Remove the tabindex=0 on this element since it serves no purpose for keyboard users or screen readers.

greenyouse added a commit to greenyouse/react-responsive-carousel that referenced this issue Jan 31, 2021
greenyouse added a commit to greenyouse/react-responsive-carousel that referenced this issue Apr 2, 2021
leandrowd added a commit that referenced this issue Jul 2, 2021
gh-545: Remove tabindex for non-interactive div
@stale
Copy link

stale bot commented Aug 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 1, 2021
@stale stale bot closed this as completed Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant