Fix dev dependencies #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Can't build with current package.JSON)
Should be commited for reproducibility reasons
Unnecessary for the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main point of this PR is to fix the development dependencies which were broken for the modern vscode types API, as vscode changed slightly how their types are imported. See f7f384c. So now you actually should be able to build the extension after running
npm install. HOWEVER, I have not checked whether users would need to update to vscode version ^1.66.0. I have not actually changed any source code, so changing"@types/vscode": "^1.66.0"to"@types/vscode": "^1.17.0"should be safe.package-lock.json was removed from the .gitignore for reproducibility of builds (8a36bb4), I added a few snippets (38fcdf4), and removed unnecessary files from the installed extension for users (1527c36).
Besides all that, a few typos and such were fixed in the source code (b314bef, 494dc36).