Added OneMap (Singapore)

[kyroskoh]

No description provided.

[jieter]

@kartenkarsten thanks for the pull. For reference, can you provide a link to this providers TOS in a comment here?

[brunob]

Thx for the patch, this seems good to me but i'm not sure the image in the attribution is really usefull.

[jieter]

It seems that the variant options are mostly equal to the base provider options. If that's the case, they can be removed from the variants options map.

Can you have a look at how the other providers are defined and de-duplicate the definition?

[jieter]

@kyroskoh thanks for the PR, I merged it and did the requested changes, see commit 9732ecb

[jieter]

The OneMapSG layers can be seen in action here:

http://leaflet-extras.github.io/leaflet-providers/preview/#filter=OneMapSG

[jieter]

released 1.4.0

[brunob]

👍 @jieter :)

[kyroskoh]

@brunob The attribution logo is needed as it is part of the Trademark of OneMap SG.

[brunob]

@kyroskoh like @jieter said :

can you provide a link to this providers TOS in a comment here?

[kyroskoh]

@brunob @jieter

About OneMapSG: https://www.onemap.sg/main/v2/about
OneMapSG Intro Deck: https://www.onemap.sg/home/
OneMapSG TOU: https://www.onemap.sg/legal/termsofuse.html

Attribution is found in:
OneMapSG Version of Leaflet: https://cdn.onemap.sg/leaflet/onemap-leaflet.js
OneMapSG Basemaps: https://docs.onemap.sg/maps/

[brunob]

I've read https://www.onemap.sg/legal/termsofuse.html and could not find any mention to a way of crediting original website. Maybe the best options would be to contact them to ask if the image have to be present in credits.

[kyroskoh]

@brunob I was being told by them to use the same attribution that they have declared. Do you want to contact them to ask about it? You can email them via onemap[at]sla.gov.sg

[brunob]

@kyroskoh 'k let's go for the image in credits :)