Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate example Mapbox ID in README #364

Closed
philgyford opened this issue Aug 26, 2020 · 1 comment · Fixed by #365
Closed

Inaccurate example Mapbox ID in README #364

philgyford opened this issue Aug 26, 2020 · 1 comment · Fixed by #365

Comments

@philgyford
Copy link
Contributor

In the README, under "Mabox" it says:

You can get map_ID (i.e mapbox.satellite)...

But I think this format ("mapbox.satellite") is inaccurate since the change to the modern Static Tiles API.

The currently-available Mapbox styles are listed here and so the possible current strings to use as the id with leaflet-providers are:

  • "mapbox/streets-v11"
  • "mapbox/outdoors-v11"
  • "mapbox/light-v10"
  • "mapbox/dark-v10"
  • "mapbox/satellite-v9"
  • "mapbox/satellite-streets-v11"

So – they now use a slash rather than a period, and have version numbers appended.
@brunob
Copy link
Member

brunob commented Aug 26, 2020

Feel free to provide a PR for that :)

philgyford added a commit to philgyford/leaflet-providers that referenced this issue Aug 26, 2020
@philgyford
Update example Mapbox map_ID
d180e10 
And link to the list of available Mapbox map styles.

Fixes leaflet-extras#364
@philgyford philgyford mentioned this issue Aug 26, 2020
Merged
brunob pushed a commit that referenced this issue Aug 26, 2020
@philgyford @brunob
Update example Mapbox map_ID
8d01363 
And link to the list of available Mapbox map styles.

Fixes #364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update example Mapbox map_ID philgyford/leaflet-providers
2 participants
@philgyford @brunob