Cron optimizations #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It is now possible to use "0" as interval to have the script just run once and then exit (useful in cron jobs) - Fixed a bug where script was not sleeping on error before trying again
|
Interesting idea, thanks! Can you rebase this on current master? |
Conflicts: dbdownload/dbdownload.py
|
It should work now, didn't test it. |
|
@coandco LGTM, can you also take a look? Thanks! |
coandco
requested changes
Dec 15, 2017
| self._logger.debug('sleeping for %d seconds' % self.sleep) | ||
| time.sleep(self.sleep) | ||
| # Done processing delta | ||
| return |
There was a problem hiding this comment.
Since the "while True" is in start() now, there's no reason to have a "while True" loop in _monitor. Remove the _monitor while loop, and I think these changes should be good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thank you for sharing this script!
I've added a couple of features to have it better run as a cron job. Feel free to merge them if you are interested.