fix: return null instead of crashing when no solution is found #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, any fix for the bug above? When trying to solve unsolvable cube, the process never stops |
ldez
force-pushed
the
feature/no-solution-found
branch
from
076d8c5
to
f97a7ac
Compare
ldez
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no solution can be found cubejs crashes while trying to access
null.This happens when
maxDepthis set too low for the current scramble.To reproduce this bug just set it to 1 (see also the added test).
I usually don't use CoffeScript, so I hope the syntax is ok. Otherwise, feel free to edit it. :)