refactor: systematically use comparison with undefined

Compare the return value of functions that return a code point or ``undefined`` with ``undefined`` (``c === undefined``) instead of just doing ``!c``.
lddubeau · Sep 12, 2019 · fff5edb · fff5edb
1 parent c1fed89
commit fff5edb
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/lib/saxes.js b/lib/saxes.js
@@ -978,7 +978,7 @@ class SaxesParser {
     if (c === LESS) {
       this.state = S_OPEN_WAKA;
     }
-    else if (c) {
+    else if (c !== undefined) {
       // have to process this as a text node.
       // weird, but happens.
       if (!this.reportedTextBeforeRoot) {
@@ -1216,7 +1216,7 @@ class SaxesParser {
       this.ondoctype(this.doctype);
       this.doctype = true; // just remember that we saw it.
     }
-    else if (c) {
+    else if (c !== undefined) {
       this.doctype += String.fromCodePoint(c);
       if (c === OPEN_BRACKET) {
         this.state = S_DTD;
@@ -1241,7 +1241,7 @@ class SaxesParser {
   /** @private */
   sDTD() {
     const c = this.captureTo(DTD_TERMINATOR, "doctype");
-    if (!c) {
+    if (c === undefined) {
       return;
     }
 
@@ -1450,7 +1450,7 @@ class SaxesParser {
       }
       this.state = c === QUESTION ? S_PI_ENDING : S_PI_BODY;
     }
-    else if (c) {
+    else if (c !== undefined) {
       this.fail("disallowed character in processing instruction name.");
       this.piTarget += String.fromCodePoint(c);
     }
@@ -1556,7 +1556,7 @@ class SaxesParser {
           return;
         }
 
-        if (c) {
+        if (c !== undefined) {
           switch (this.xmlDeclName) {
           case "version": {
             this.xmlDeclExpects = ["encoding", "standalone"];
@@ -1675,7 +1675,7 @@ class SaxesParser {
   /** @private */
   sOpenTag() {
     const c = this.captureNameChars();
-    if (!c) {
+    if (c === undefined) {
       return;
     }
 
@@ -1727,7 +1727,7 @@ class SaxesParser {
   /** @private */
   sAttrib() {
     const c = this.skipSpaces();
-    if (!c) {
+    if (c === undefined) {
       return;
     }
     if (isNameStartChar(c)) {
@@ -1799,15 +1799,15 @@ class SaxesParser {
       this.name = this.text = "";
       this.openTag();
     }
-    else if (c) {
+    else if (c !== undefined) {
       this.fail("disallowed character in attribute name.");
     }
   }
 
   /** @private */
   sAttribNameSawWhite() {
     const c = this.skipSpaces();
-    if (!c) {
+    if (c === undefined) {
       return;
     }
 
@@ -1919,7 +1919,7 @@ class SaxesParser {
     else if (c === LESS) {
       this.fail("disallowed character.");
     }
-    else if (c) {
+    else if (c !== undefined) {
       if (this.text.includes("]]>")) {
         this.fail("the string \"]]>\" is disallowed in char data.");
       }
@@ -1943,7 +1943,7 @@ class SaxesParser {
     else if (isS(c)) {
       this.state = S_CLOSE_TAG_SAW_WHITE;
     }
-    else if (c) {
+    else if (c !== undefined) {
       this.fail("disallowed character in closing tag.");
     }
   }
@@ -1954,7 +1954,7 @@ class SaxesParser {
     if (c === GREATER) {
       this.closeTag();
     }
-    else if (c) {
+    else if (c !== undefined) {
       this.fail("disallowed character in closing tag.");
     }
   }