fix: emit empty comment

lddubeau · Jul 10, 2018 · b3db392 · b3db392
1 parent 95d192f
commit b3db392
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/lib/saxes.js b/lib/saxes.js
@@ -930,9 +930,7 @@ class SaxesParser {
     const c = this.getChar(chunkState);
     if (c === "-") {
       this.state = S_COMMENT_ENDED;
-      if (this.comment) {
-        this.emitNode("oncomment", this.comment);
-      }
+      this.emitNode("oncomment", this.comment);
       this.comment = "";
     }
     else {

diff --git a/test/comment.js b/test/comment.js
@@ -0,0 +1,13 @@
+"use strict";
+
+require(".").test({
+  name: "comment",
+  xml: "<r><!--foo--><!----></r>",
+  expect: [
+    ["opentagstart", { name: "r", attributes: {} }],
+    ["opentag", { name: "r", attributes: {}, isSelfClosing: false }],
+    ["comment", "foo"],
+    ["comment", ""],
+    ["closetag", "r"],
+  ],
+});