Add coverage testing. #903
Conversation
| # | ||
| set(TEST_COVERAGE OFF CACHE BOOL "instrument compiler for code coverage analysis") | ||
| if(TEST_COVERAGE) | ||
| append("-O0 -g -fprofile-arcs -ftest-coverage" EXTRA_CXXFLAGS) |
There was a problem hiding this comment.
Please add a guard before appending options:
if(CMAKE_COMPILER_IS_GNUCXX OR (${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang"))
the else branch should be a warning that coverage testing is not available.
|
Otherwise looks good to me. Thanks!!!! |
|
I added the guard, but don't merge yet, please. I want to mute the verbose gcov output by redirecting and also to enable after_success for test coverage builds only. I'll post another message here, when it's done. |
|
Now everything seems to be ok. Pretty good coverage 85.92%. |
|
Let's give this a go. I enabled coveralls.io for ldc-developers/ldc. |
|
By the way, to close an issue, just include "GitHub: Closes #380" in the commit message (the "GitHub" part actually isn't needed, but I like to include it for clarity should we ever move issue trackers). |
|
OK, I'll do it like that next time I'll commit something that closes an issue. Unless you already have it, might be a good idea to keep a checklist for contributors with all these details. I know there is a wiki page about how to contribute, but somehow there are several steps just to reach from the repository's readme. |
|
Seems like the results appeared on Coveralls.io just fine. Thanks for the great work! (For the badge, we'll need to wait until camo.githubusercontent.com updates its cache.) |
This PR enables collecting gcov code coverage statistics and pushing them to coveralls.io. It also adds the coveralls badge to README. Someone with access to ldc-developers account has to create/connect a coveralls.io account to ldc-develoepr/ldc repository to make this work. This PR should close the issue #380. I enabled test coverage for llvm 3.5 build, but of course any other one can be used as well. Please, review.