Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Compile shared Phobos libs to a single object file #3757

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

kinke
Copy link
Member

@kinke kinke commented Jun 10, 2021

(Only) when compiling them all-at-once anyway; primarily for implicit cross-module inlining across the same library.

This won't work as long as there are multiple conflicting declarations across a library's modules - issue #2782.

@kinke
Copy link
Member Author

kinke commented Jun 10, 2021

Argh, it's not just conflicting declarations in the libraries, but also mismatches regarding the (simplified) compiler forward declarations...

@kinke kinke changed the title CMake: Compile shared druntime/Phobos libs to a single object file CMake: Compile shared Phobos libs to a single object file Jun 10, 2021
(Only) when compiling them all-at-once anyway; primarily for implicit cross-
module inlining across the same library.

This won't work as long as there are multiple conflicting declarations
across a library's modules - issue ldc-developers#2782.
As compiling Phobos to a single object file apparently really works
already.
@kinke kinke marked this pull request as ready for review June 10, 2021 23:25
@kinke
Copy link
Member Author

kinke commented Jun 10, 2021

Phobos actually already works, what a nice surprise. :)

@kinke kinke merged commit 2f0ece3 into ldc-developers:master Jun 14, 2021
@kinke kinke deleted the shared_libs_single_obj branch June 14, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant