Fix linker cmdline length limitation via response files #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ldc-developers#3535 and an issue for ldmd2 wrt. unquoted args containing spaces in response files for ldc2 (uncovered during manual tests). Also create the temporary response files in the temp directory, not in the current working dir.
kinke
force-pushed
the
fix3535
branch
2 times, most recently
from
0a39c0d
to
c775ede
Compare
By hiding the common functionality behind args::executeAndWait(). Also make sure to properly escape quoted args in response files.
kinke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3535 and an issue for ldmd2 wrt. unquoted args containing spaces in response files for ldc2 (uncovered during manual tests). Also create the temporary response files in the temp directory, not in the current working dir.