Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade front-end & libs to v2.088.0 #3143

Merged
merged 12 commits into from
Sep 7, 2019
Merged

Conversation

kinke
Copy link
Member

@kinke kinke commented Aug 24, 2019

No description provided.

@kinke
Copy link
Member Author

kinke commented Aug 26, 2019

I assume we don't support representing DMD's new (and undocumented) -fPIE with a combination of existing cmdline options; I played around with -relocation-model, but wasn't able to replicate clang's asm with -fPIE (https://godbolt.org/z/6Sibvr). clang's cmdline options logic in this regard is a nightmare...

The Win32 unittest failure will be fixed by dlang/phobos#7156.

@kinke kinke marked this pull request as ready for review August 27, 2019 19:54
@JohanEngelen
Copy link
Member

nice that you included a link to Clang's PIC/PIE logic, oof... I'm OK with not supporting -fPIE for now. Open an issue for someone to workout what the cmdline options should be to get same asm output as clang?

@kinke kinke changed the title Upgrade front-end & libs to v2.088.0-beta.1 Upgrade front-end & libs to v2.088.0 Sep 3, 2019
@kinke kinke merged commit f3fe277 into ldc-developers:master Sep 7, 2019
@kinke kinke deleted the merge-2.088 branch September 7, 2019 18:00
@kinke kinke mentioned this pull request Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants