-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade front-end & libs to v2.085.0 #3003
Conversation
Union regression: dlang/dmd#9288 |
22ab436
to
cb4273b
Compare
Still to do:
Should be green otherwise. |
e484486
to
86eeebd
Compare
Besides dcompute and ObjC failures, there's a new druntime standalone test (GC) which fails on both Linux and Mac with shared druntime. |
Can the definition of RTInfo be versioned out for dcompute? I suspect it doesn't help to have precise GC info with that target.
The GC tests rebuild a couple of modules and expect to replace the original ones from the static library. I doubt that works with the runtime in a shared library. |
Thx for the hints, Rainer.
AFAIK, the dcompute specifics are per-module (i.e., you can compile normal modules alongside dcompute modules in one run), so there's no predefined version for dcompute. I guess the automatic The module replacement not working with shared libs seems to make perfect sense. |
That is correct, but not quite the whole story, can designate a module for both the host and device. There are a number of ways this could be fixed: |
[Just for the record, I won't tackle the |
This reverts dlang/dmd@f35ff8024c2c, which changed the base type from int to ubyte. That led to a enum C++ mangling issue, at least for MSVC targets: https://issues.dlang.org/show_bug.cgi?id=19658 Even if the mangling is fixed, older host compilers wouldn't be able to compile 2.085-based LDC, so revert to int.
Reusing parsing and usage functionality from DMD, as the number of these is likely to grow.
Only display the appropriate usage help (and then fail) if invoked without any explicit cmdline options. Otherwise emit an error about missing source files and fail immediately, without displaying the usage help. Besides making LDC and LDMD behave identically in this regard, it makes just more sense IMO (when forgetting to specify a file, LDC previously just printed the cmdline help without any error message). It also makes `ldmd2 -transition=?` and `ldmd2 -preview=help` etc. print the expected help without LDMD special cases.
It's already not generated by the frontend if the template is not defined, so disabling it with |
No description provided.