Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

returned attribute for struct constructors #637

Closed
dnadlinger opened this issue Jun 20, 2014 · 0 comments
Closed

returned attribute for struct constructors #637

dnadlinger opened this issue Jun 20, 2014 · 0 comments
Labels
B-suboptimal-code

Comments

@dnadlinger
Copy link
Member

We should add the returned attribute to struct constructors, since they return the passed in this pointer. However, the code has been disabled due to a type mismatch (#624). Needs further investigation.
dnadlinger added a commit that referenced this issue Sep 27, 2014
@dnadlinger
Merge pull request #637 from JakobOvrum/cputf8
c0978e9 
Add declaration of CP_UTF8
redstar added a commit to redstar/ldc that referenced this issue Nov 13, 2014
@redstar
Fix for issue ldc-developers#637.
dbbbe00 
In case of a ctor `this` is passed to the function and is also the
return value. This is the perfect case for the `Returned` attribute.
But the x86_64 ABI missed the fact that the return value was a pointer
to a struct and did a struct rewrite, resulting in an bitcast
incompatible type.
redstar added a commit that referenced this issue Nov 13, 2014
@redstar
Merge pull request #787 from redstar/issue637
10b35d7 
Fix for issue #637.
redstar added a commit to redstar/ldc that referenced this issue Nov 13, 2014
@redstar
Add test case for issue ldc-developers#637
e56383c
@redstar redstar closed this as completed Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-suboptimal-code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dnadlinger @redstar