-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BFP 265] additional instances #123
Open
f-osorio
wants to merge
23
commits into
main
Choose a base branch
from
bfp-265-additional-instances
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+99
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function can now create either an instance or a secondary instance depending on if the function is passed an lccn. No lccn = secondary instance lccn = normal instance
The bottom half of the button was unclickable
Handle when someone tries to paste from an additional instance, but the target profile doesn't have an additional instance. It will paste in to the existing instance.
This ensures that everything updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://staff.loc.gov/tasks/browse/BFP-265
Adds the ability to add additional instances. This modifies the code for "Secondary Instances" to be able to create either a secondary instance or an additional instance.
Also adds the ability to delete instances, expect for the first instance in the record. Each Instance also has a label to try and help with navigation when scrolling.