Add accessibility check for function definition in public API visitor

Fix SonarOpenCommunity#402
lcintrat · Jan 25, 2015 · 641d51b · 641d51b
1 parent 472a27b
commit 641d51b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/cxx-squid/src/main/java/org/sonar/cxx/visitors/AbstractCxxPublicApiVisitor.java b/cxx-squid/src/main/java/org/sonar/cxx/visitors/AbstractCxxPublicApiVisitor.java
@@ -342,9 +342,17 @@ private void visitMemberDeclaration(AstNode memberDeclaration) {
     }
 
     private void visitFunctionDefinition(AstNode functionDef) {
-        visitMemberDeclarator(functionDef);
+        if (isPublicApiMember(functionDef)) {
+            visitMemberDeclarator(functionDef);
+        }
     }
 
+    /**
+     * Find documentation node, associated documentation,
+     * identifier of a <em>public</em> member declarator and visit it
+     * as a public API. 
+     * @param node the <em>public</em> member declarator to visit
+     */
     private void visitMemberDeclarator(AstNode node) {
 
         AstNode container = node.getFirstAncestor(

diff --git a/cxx-squid/src/test/resources/metrics/public_api.h b/cxx-squid/src/test/resources/metrics/public_api.h
@@ -92,6 +92,9 @@ struct testStruct {
      * bitfield doc
      */
     unsigned int bitfield:1;
+
+private:
+    void private_def(){}
 };
 
 /**