fix(dataflow): wait for kafka topic creation #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc525
changed the title
sakoush
approved these changes
Feb 26, 2024
scheduler/data-flow/src/main/kotlin/io/seldon/dataflow/kafka/KafkaAdmin.kt
Show resolved
Hide resolved
scheduler/data-flow/src/main/kotlin/io/seldon/dataflow/kafka/KafkaAdmin.kt
Show resolved
Hide resolved
Kafka topic creation happens asynchronously. This means that even when the return value from `createTopics(...)` indicates that the topic has been created successfuly, the topic can not be immediately subscribed to. Instead of verifying the status of the topic from the `createTopics` return value, here we're repeatedly calling `describeTopics` until all of the topics for the pipeline can be described successfully. This indicates that the topic has been fully created _at least_ on one broker, and can now be subscribed to.
lc525
force-pushed
the
fix.dataflow.kafka-wait-for-topic-creation
branch
from
c544b45 to
8b70780
Compare
lc525
merged commit 1b367d7
into
fix.dataflow.kafka-streams-state-cleanup
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Kafka topic creation happens asynchronously. This means that even when the return value from
createTopics(...)indicates that the topic has been created successfuly, the topic can not be immediately subscribed to.Instead of verifying the status of the topic from the
createTopicsreturn value, here we're repeatedly callingdescribeTopicsuntil all of the topics for the pipeline can be described successfully. This indicates that the topic has been fully created at least on one broker, and can now be subscribed to.Which issue(s) this PR fixes:
Fixes dataflow component for #INFRA-663 (internal): Pipeline creation goes into ERROR state
** PR Merge Sequencing GROUP 663 **
This is part of a sequence of PRs building on each-other, but split in order to simplify reviewing.
This PR has sequence no: G663/2