Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change trending window to 6 hours #2484

Merged
merged 1 commit into from
Sep 30, 2019
Merged

change trending window to 6 hours #2484

merged 1 commit into from
Sep 30, 2019

Conversation

lyoshenka
Copy link
Member

@lyoshenka lyoshenka commented Sep 25, 2019

@eukreign is this all I need to change, or does TRENDING_DATA_POINTS need to be changed as well. the comment on TRENDING_DATA_POINTS was not clear to me.

Does this change require a resync for the wallet server?

@lyoshenka lyoshenka added area: hub type: improvement Existing (or partially existing) functionality needs to be changed labels Sep 25, 2019
@eukreign
Copy link
Member

eukreign commented Sep 30, 2019

@eukreign is this all I need to change, or does TRENDING_DATA_POINTS need to be changed as well. the comment on TRENDING_DATA_POINTS was not clear to me.

TRENDING_WINDOW is frequency and TRENDING_DATA_POINTS is how much data to track, they can be modified independently.

Does this change require a resync for the wallet server?

Yes, this requires resync.

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #2484 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2484      +/-   ##
=========================================
+ Coverage   75.54%   75.6%   +0.06%     
=========================================
  Files         168     168              
  Lines       22574   22574              
=========================================
+ Hits        17053   17067      +14     
+ Misses       5521    5507      -14
Impacted Files Coverage Δ
lbry/lbry/wallet/server/db/trending.py 97.72% <100%> (ø) ⬆️
lbry/lbry/dht/protocol/protocol.py 81.14% <0%> (+0.42%) ⬆️
torba/torba/client/basenetwork.py 91.25% <0%> (+1.52%) ⬆️
torba/torba/server/daemon.py 55.79% <0%> (+2.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa90257...037be16. Read the comment docs.

@eukreign eukreign merged commit 9c5b4e3 into master Sep 30, 2019
@eukreign eukreign deleted the update_trending_window branch September 30, 2019 15:25
@lyoshenka lyoshenka mentioned this pull request Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: hub type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants