load all finished blobs into the node datastore #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is to better handle nodes storing to us after we've restarted our node
shyba
approved these changes
Jul 2, 2018
lbrynet/core/BlobManager.py
Outdated
| return defer.succeed(True) | ||
| if self._node_datastore is not None: | ||
| blob_hashes = yield self.storage.get_all_finished_blobs() | ||
| self._node_datastore.completed_blobs.update(blob_hashes) |
There was a problem hiding this comment.
Maybe add it decoded as it's how hashes are stored on DHT classes? Also maybe not directly over the attribute but over a method so BlobManager keeps handling hex encoded hashes while DHT handles decoded ones to keep expectations/consistent in check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-accept invalid store tokens for the first expire-time after startup