fix large file uploads #7736
Merged
fix large file uploads #7736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessopb
force-pushed
the
fix-LargeFileUploads
branch
from
41197f5
to
5cfb949
Compare
electron-builder/issues/6124 says regressions happen after this version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron IPC messages have to serialize data and over 1GB or so, this causes a crash.
As I think we have to at least load small files to continue handling posts the way we were, we'll keep sending the buffer for under 500MB, but use ffprobe to get duration in the electron main process instead of relying on creating a browser File object.