-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove blocked and filtered reducers/selectors/actions. #7682
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I don't think there's any reason to leave those empty arrays in. Removing them can only simplify the related components. Yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the linter complaining:
Error --------------------------------------------------------------------------------- ui/redux/actions/claims.js:93:22
Cannot get `uriResolveInfo.error.censor` because property `censor` is missing in mixed [1].
ui/redux/actions/claims.js:93:22
93| ...uriResolveInfo.error.censor,
^^^^^^^^^^^^^^^^^^^^^^^^^^^
References:
/tmp/flow/flowlib_61141ec/core.js:48:51
48| static entries(object: mixed): Array<[string, mixed]>;
^^^^^ [1]
Error --------------------------------------------------------------------------------- ui/redux/actions/claims.js:94:25
Cannot get `uriResolveInfo.error.text` because property `text` is missing in mixed [1].
ui/redux/actions/claims.js:94:25
94| text: uriResolveInfo.error.text,
^^^^^^^^^^^^^^^^^^^^^^^^^
References:
/tmp/flow/flowlib_61141ec/core.js:48:51
48| static entries(object: mixed): Array<[string, mixed]>;
^^^^^ [1]
```
Thank you @jessopb, sadly I couldn't fix it without using I tried typecasting but it kept complaining about not being compatible with |
This will be merged when infrastructure is ready. |
29dbbc2
to
6d52763
Compare
Fixes
Issue Number: #7681
What is the current behavior?
What is the new behavior?
blocked & filtered actions/selector/reducers were removed.
Also, if there is a censor reason, we will display it.
If no message is present, the default one will be used
("Your hub has blocked this content because it subscribes to the following blocking channel:")
Other information
PR Checklist
Toggle...
What kind of change does this PR introduce?
Please check all that apply to this PR using "x":