Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to rename private/unpublished lists. #7519

Merged
merged 6 commits into from
Mar 29, 2022

Conversation

Ruk33
Copy link
Collaborator

@Ruk33 Ruk33 commented Mar 23, 2022

Fixes

Issue Number: #6257

What is the current behavior?

Users can't rename private/unpublished lists.

What is the new behavior?

Users can rename private/unpublished lists.

image
image
image

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

@jessopb
Copy link
Member

jessopb commented Mar 23, 2022

Code looks good, but it's hard to use our bulky existing styles here. The real answer here is a large style refactor. Short term could be a new slim style. I can take a look soon.

@jessopb
Copy link
Member

jessopb commented Mar 23, 2022

Testing it some more, I think there isn't room for the rename on the card and it is best to do it on the edit page.
After you get it working on "view list" page, let me know and I'll adjust the styles if you like.

Copy link
Member

@jessopb jessopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but let's move it to edit page. See comments

@Ruk33 Ruk33 force-pushed the 6257-ability-to-rename-a-playlist branch from a7235d2 to e814d00 Compare March 28, 2022 18:21
@Ruk33 Ruk33 force-pushed the 6257-ability-to-rename-a-playlist branch from e814d00 to f41c0d6 Compare March 28, 2022 18:32
@jessopb jessopb merged commit e0c2f03 into master Mar 29, 2022
@jessopb jessopb deleted the 6257-ability-to-rename-a-playlist branch March 29, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants