Additional pop up menu options

[rafael-xmr]

PR Checklist

Please check all that apply to this PR using "x":

• I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
• I have checked that this PR does not introduce a breaking change
• This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting)
• Refactoring (no functional changes)
• Documentation changes
• Other - Please describe:

Fixes

Issue Number: Closes #5782

What is the current behavior?

What is the new behavior?

On own content:

Other information

just missing playlist stuff for now

[rafael-xmr]

Notable new changes:

-Reverted myActiveClaims

-Added some toasts for menu actions:

-Muting and Blocking toast will link to the /block_and_mute settings page, which is a way for the action to be undone since the content being muted or blocked disappears from the page:

-Switched up what Mute and Block messages display on toast, to clear confusion:

-Also changed up redux code a little to separate better Mute from Unmute, and Subscribe from Unsubscribe, like how it already works for Block and Unblock

[rafael-xmr]

Explaining my final solution to claimIsMine:

I added a new selector called makeSelectSigningIsMine, which is similar to makeSelectClaimIsMine but instead it returns true when signing_channel is mine, which then solves the issue of not returning true on the search page:

And also prevents Reposts from returning true, as your claims, which would show on the menu pop up options like "edit" or "delete", and would break trying to edit or delete the reposted content

[tzarebczan]

By search page do you mean the lighthouse results? We can fix that by adding the --include_is_my_output parameter to claim searches and resolves. Looks like we don't pass this in a few places that we should (i.e. homepages, top search result).

I think that's the better way of doing it so it's consistent with the previous method we use for checking ownership.

For claims that are your own, should also hide the mute/block button if it's not muted (allow unmute/unblock if it is).

[rafael-xmr]

I think that's the better way of doing it so it's consistent with the previous method we use for checking ownership.

Hmm I think so too, that one might be it then

For claims that are your own, should also hide the mute/block button if it's not muted (allow unmute/unblock if it is).

Hide mute/block and show unmute/unblock? why not hide both? can you even mute/block your own claims?

[tzarebczan]

Shouldn't allow to block/mute your own, but if someone did, should allow unmuting/blocking.

Pushed on rebased version, before playlists. I can try to take a stab at rebasing on playlists later - unless you want to:?

Some bugs:

• channel analytics option doesn't load the channel on the analytics page (I see it in the URL, but loads my default).
• should probably hide options that are already visible on certain pages:
  

Nice to have:

• support reposts for deletion button (i.e. I have a repost on my channel page > I can menu > delete.

[rafael-xmr]

Shouldn't allow to block/mute your own, but if someone did, should allow unmuting/blocking.

✔️

Pushed on rebased version, before playlists. I can try to take a stab at rebasing on playlists later - unless you want to:?

✔️Merged playlists changes

Some bugs:

• channel analytics option doesn't load the channel on the analytics page (I see it in the URL, but loads my default).

✔️Fixed

• should probably hide options that are already visible on certain pages:

✔️Now only shows options that are not already on screen

Nice to have:

• support reposts for deletion button (i.e. I have a repost on my channel page > I can menu > delete.

✔️ Now working

[jessopb]

Looking better -
I think it would be better to use the query param that comes from the analytics button and use that to set the active channel on the dash component.
If you just want to ship what you have, strip the analytics item out.
I don't think passing setActiveChanged into the SelectChannel component is the best way.