Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add ability to export transactions #5899

Merged
merged 5 commits into from
Apr 23, 2021
Merged

Conversation

infinite-persistence
Copy link
Contributor

@infinite-persistence infinite-persistence commented Apr 16, 2021

Issue

Closes #4793 Export Wallet History For Taxation Purposes

Requires lbry-redux update

Screenshots

  • Start:
    • image
  • Fetching:
    • image
  • In the unlikely-event that the fetched data couldn't be parsed:
    • image
  • Fetched and file is ready:
    • image

@tzarebczan
Copy link
Contributor

Took about a minute on my wallet, will try some other large ones. Not bad...

I noticed support_list is called - is that data used anywhere? we shouldn't need anything outside of transaction list.

99K may be too small for some of the larger creators, so let's add another 9. We'll deal with performance issues/run manually for others as needed.

@infinite-persistence
Copy link
Contributor Author

I noticed support_list is called - is that data used anywhere? we shouldn't need anything outside of transaction list.

Wanted to ask that as well. @seanyesmunt, safe to remove doFetchSupports?

export function doFetchTransactions(page = 1, pageSize = 99999) {
  return dispatch => {
    dispatch(doFetchSupports());   // <---- ??
    dispatch({
      type: ACTIONS.FETCH_TRANSACTIONS_STARTED,
    });

    Lbry.transaction_list({ page, page_size: pageSize }).then(result => {
      dispatch({
        type: ACTIONS.FETCH_TRANSACTIONS_COMPLETED,
        data: {
          transactions: result.items,
        },
      });
    });
  };
}

@infinite-persistence
Copy link
Contributor Author

infinite-persistence commented Apr 20, 2021

Took about a minute on my wallet, will try some other large ones. Not bad...

  • Pondering if we need to add notification (desktop) or toast (web) for "Transactions file ready for download".
    • Notifications Page would be better, but not available for Desktop/non-signed in users
  • "Fetching data..." would then need to be something like "Fetching data; check back here later".

@infinite-persistence
Copy link
Contributor Author

UPDATE

  • Removed support-fetching
  • Bumped pageSize

Closes 4793: Export Wallet History For Taxation Purposes
Don't let the file-creation process block the GUI.

Requires lbry-redux update.
@infinite-persistence
Copy link
Contributor Author

UPDATE

  • Resolve conflict in changelog

REMINDER

  • Another lbry-redux merge is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Wallet History For Taxation Purposes
2 participants