Revamp search filters #5742
Merged
Revamp search filters #5742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, bob is testing this. |
infinite-persistence
force-pushed
the
ip/search-filter-4945
branch
from
bc9ae49
to
55a6c9b
Compare
|
|
infinite-persistence
force-pushed
the
ip/search-filter-4945
branch
2 times, most recently
from
9fcf5dc
to
eb18680
Compare
|
No more known pending changes at this moment. |
|
|
infinite-persistence
force-pushed
the
ip/search-filter-4945
branch
from
c1bd8c9
to
e2b8685
Compare
|
|
neb-b
reviewed
Apr 6, 2021
ui/page/search/index.js
Outdated
|
|
||
| return { | ||
| isSearching: selectIsSearching(state), | ||
| showNsfw: showMature, | ||
| uris: uris, | ||
| isAuthenticated: selectUserVerifiedEmail(state), | ||
| searchOptions: selectSearchOptions(state), | ||
| isQueryMaxed: isQueryMaxed, |
There was a problem hiding this comment.
maybe something like hasReachedMaxResultsLength?
There was a problem hiding this comment.
Sounds good. Also, I'll rebase to fix the conflict
|
I will do a styling pass and push up a commit. Then it can be merged. |
- This change makes it work for both Desktop and Odysee. When merging back to Odysee, just take the file from `master` (barring any changes from someone else). - Given that we'll be opening up the search filter for Odysee, the only "simple site" customization that was back-ported is `free_only=true`.
## Issue 4945: Simplify / revamp search filters for odysee (and lbry.tv) ## Changes - Tweaked the "claim type = file | channel | everything" a little to hopefully make it more intuitive. - Added "Sort By". - Added "Upload Date". - Fixed the affected files to handle both Desktop and Odysee. - Tweaked the layout to be more condensed so that we can see some results as we change the filter. - Added animations. - Added "Exact match" option that helps user to surround with quotes.
Requires further work in IAPI
infinite-persistence
force-pushed
the
ip/search-filter-4945
branch
from
e2b8685
to
ee5815c
Compare
|
@seanyesmunt feel free to add the GUI pass commits, but hold off the merge due to the bug. |
|
@seanyesmunt,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #4945: Simplify / revamp search filters for odysee (and lbry.tv)
"Infinite scroll" will be attempted in another PR.AddedMerging notes
ui/util/query-param.jsui/component/searchOptions/view.jsxWhen merging into Odysee, solve the conflict for the above 2 files by simply taking the
masterversion directly. It has been updated to handleSIMPLE_SITE.Changes
claim type = file | channel | everythingwidget a little to hopefully make it more intuitive.Differences with Odysee
This will happen automatically when merged to Odysee:
"Result Count" will be hiddenNo more "results count" for all platforms after adding infinite scroll.Click to expand...