Don't close main player when editing comments #5606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
approved these changes
Mar 3, 2021
https://discord.com/channels/362322208485277697/363087331475062785/815132676293918730 - Renamed `closeInlinePlayer` to `clearPlayingUri` to reflect it's actual function. - Add additional check to see if the current video is actually inline before closing it. Wanted to refactor out an actual `closeInlinePlayer`, but let's wait until there are more usages.
infinite-persistence
force-pushed
the
ip-close-inline
branch
from
d4c1d91
to
f3a98b0
Compare
|
|
infinite-persistence
force-pushed
the
ip-close-inline
branch
from
f3a98b0
to
f34d073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://discord.com/channels/362322208485277697/363087331475062785/815132676293918730
Related
#5384: Editing a comment that has an embed in the playing state, doesn't hide the player
Changes
closeInlinePlayertoclearPlayingUrito reflect it's actual function.Wanted to create an actual
closeInlinePlayer, but let's wait until there are more usages.Note
I've tested the "main player" case (don't stop the video), but I couldn't test the "inline player" case (should close the video) as I couldn't create a comment today. Kept receiving failure.Never mind. The Comments Server is working again and I was able to test out both cases.