"Fix Long commenter name issue" #5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
suggested changes
Jan 29, 2021
ui/scss/component/_button.scss
Outdated
| @@ -242,6 +242,7 @@ | |||
| } | |||
|
|
|||
| .button__label { | |||
| max-width: 10rem; | |||
There was a problem hiding this comment.
I would like to avoid adding this to the generic button style. Can you add it here instead?
https://github.com/lbryio/lbry-desktop/blob/master/ui/scss/component/_comments.scss#L195
There was a problem hiding this comment.
Thank you @seanyesmunt , I've changed it, I hope it's ok.
|
Tested and works great! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number:
#3930
What is the current behavior?
Long commenter name (channel name) causes the whole comment wrapper to be expanded
What is the new behavior?
Long commenter name (channel name) no longer causes the whole comment wrapper to be expanded.
Other information