Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing inline videos in comments #5389

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Conversation

DanielaNarvaez
Copy link
Contributor

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #5384

What is the current behavior?

Editing a comment that has an embed in the playing state, doesn't hide the player

What is the new behavior?

Editing a comment that has an embed in the playing state, does hide the player

Other information

Copy link
Contributor

@DispatchCommit DispatchCommit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a type declaration for the new prop closeInlinePlayer in in the type declaration here:

should fix that linting error. Thanks for the quick fix!

@DanielaNarvaez
Copy link
Contributor Author

Oh sorry about that. I just sent the changes.

@neb-b
Copy link

neb-b commented Jan 26, 2021

@Daninz Thank you for this PR! It looks great 🙂

@neb-b neb-b merged commit e9d2891 into lbryio:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing a comment that has an embed in the playing state, doesn't hide the player
3 participants