Video: Mobile UI + overlay for keyboard shortcut feedback #5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinite-persistence
force-pushed
the
ip-vjs-overlay
branch
from
dfbbe4a
to
32fbd26
Compare
|
|
|
Will look at this after the desktop release is out. Hopefully soon 😞 |
infinite-persistence
force-pushed
the
ip-vjs-overlay
branch
3 times, most recently
from
8caaaa0
to
e371023
Compare
infinite-persistence
changed the title
|
|
neb-b
suggested changes
Dec 9, 2020
ui/component/viewers/videoViewer/internal/plugins/videojs-overlay/LICENSE
Outdated
Show resolved
Hide resolved
infinite-persistence
force-pushed
the
ip-vjs-overlay
branch
from
54d86c1
to
53e2131
Compare
|
|
|
I think we still need one of the licenses (don't remember which one). It said it had to be included with the code I think. |
…ctly without waiting for an event.
The plugin only supports event-based overlays. This change will provide the functionality of an "one-off" overlay, which will be display immediately upon the 'player.overlay({...})' call, and hides when the 'end' event hits.
…functional change.
This is an improvement to 28e7fec, which back then I just made the video control-bar re-appear when the shortcut is pressed, so that user gets to see the latest playback rate value. Now, it uses a transient overlay.
…ntrolBar), causing the controlBar to be unresponsive to touch. For some reason, adding the "-1" to the logic places it 2 slots behind the desired array slot, plus the actual item ends up being at the bottom of the DOM. Removing the "-1" places it exactly at that index and pushes all existing items down 1 slot (feels like correct behavior), plus the final DOM is also correct. Perhaps it's just some changes in videojs upstream that videojs-mobile-ui haven't catch up on (it has been dormant since 2018).
- Since the whole overlay is now the control bar, the bottom control bar should no longer be black (too focused). - Gray out the video when the overlay is up. - The 'play/pause' is now at the middle of the overlay, so hide the one in the bottom controlBar. The bigger button is easier to tap in smaller mobile screens.
This makes more sense and also matches the controlBar's behavior.
- Restored the control-bar when playback rate is changed via keyboard. - Also show the control-bar when seeking via keyboard. Aside: lint was complaining about a potentially-null 'player', so added the null check in front and removed the redundant ones below.
## Issue 4889: Alt-Left shouldn't impact video ... since that is the common combo for navigation in browsers. It ended up doing 2 things.
infinite-persistence
force-pushed
the
ip-vjs-overlay
branch
from
c53cb42
to
53cb595
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
play/pausebuttonApproach
ui/component/videoViewer/internal/pluginwill contain the plugin files. Changes done to these files will be minimal so ease any future patching from the original source. The inline method is used to handle importing issues with Node modules.Note to reviewer
Also
Closes #4889: Alt-Left shouldn't impact video