Block mature content when access directly from URL #4560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinite-persistence
force-pushed
the
ip-4549-block-mature-direct
branch
from
ab3f560
to
a1e544c
Compare
neb-b
suggested changes
Jul 23, 2020
ui/component/fileTitle/view.jsx
Outdated
| <FileActions uri={uri} /> | ||
| isNsfwBlocked ? ( | ||
| <div className="main--empty"> | ||
| <h2 className="card__title card__title"> |
There was a problem hiding this comment.
Since they are in the same card, this shouldn't use card__title. I think the generic h2 will work.
ui/component/fileTitle/view.jsx
Outdated
| settings: <Button button="link" label={__('Content Settings')} navigate={`/$/${PAGES.SETTINGS}`} />, | ||
| }} | ||
| > | ||
| Change %settings% |
## Issue: Fixes 4549 `Mature content + navigating to URLs directly` _If a user navigates to mature content directly, we currently show the page even if mature content setting is not enabled. With our recent mature content verification setting, we should hide the page until the user turns it on - we can prompt directly on the file page._ ## Changes: 1. Show basic info of the claim like URL and Title, so that user knows which page is being blocked. 2. Initially, I had 2 "boxes" -- one for the title and another for the message. It felt a bit messy, so `FileTitle` was augmented to house everything in one box.
infinite-persistence
force-pushed
the
ip-4549-block-mature-direct
branch
from
a1e544c
to
9b77aeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #4549 Mature content + navigating to URLs directly
Changes:
FileTitlewas augmented to house everything in one connected box.