Fix channel file-search not available in mobile #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding changelog: |
infinite-persistence
force-pushed
the
ip-4524-channel-search-missing
branch
from
7629bb7
to
78239a0
Compare
neb-b
suggested changes
Jul 15, 2020
infinite-persistence
force-pushed
the
ip-4524-channel-search-missing
branch
from
78239a0
to
68cfd0d
Compare
## Issue Fixes 4524 `[mobile] in channel search not available` ## Changes There are currently 3 wunderbars: (1) header (2) channel list (3) downloaded list. The additional `wrapperStyle` in the header made it hard to find a solution that works for all 3, so I split 2 and 3 into `wunderbar__input--inline`.
neb-b
force-pushed
the
ip-4524-channel-search-missing
branch
from
68cfd0d
to
c6e023c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Fix channel file-search not available in mobile
Issue
Fixes #4524
[mobile] in channel search not availableChanges
There are currently 3 wunderbars: (1) header (2) channel list (3) downloaded list.
The additional
wrapperStylein the header made it hard to find a solution that works for all 3, so I split 2 and 3 intowunderbar__input--inline.(2) Fix "More" toggle button not having bottom space.
Issue
This button is usually placed beside the
Trending|New|Topselector, so it should have the same bottom margin. If not, anything that flows below it (e.g. in mobile) will be touching it.