Fix unmuted state lost or reverted when playing a new video. #4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding changelog: |
infinite-persistence
force-pushed
the
#4460-lost_unmute
branch
from
e88df52
to
9378c7c
Compare
|
I tried fixing the conflict from github.com but failed. @infinite-persistence Can you rebase this? You can push over my 'merge' commit. |
infinite-persistence
force-pushed
the
#4460-lost_unmute
branch
from
252b94f
to
ffd2857
Compare
|
Rebased to equivalent spot. |
## Issue Fixes 4460 `unmuted state lost / reverted` 1. Play a video. 2. Press mute. 3. Drag the volume bar to unmute. 4. Play a new video --> the video starts muted. ## Fix The `volumechange` handler was comparing against stale variables, so there are times where the state was not saved. Just save both `muted` and `volume` without additional gating (the gating is probably unnecessary in the first place, since we are in a onChange function).
|
Rebasing again to latest master since there's another conflict in the changelog (might as well): |
infinite-persistence
force-pushed
the
#4460-lost_unmute
branch
from
ffd2857
to
b859d76
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4460
unmuted state lost / revertedFix
The
volumechangehandler was comparing against stale variables, so there are times where the state was not saved. Just save bothmutedandvolumewithout additional gating (the gating is probably unnecessary in the first place, since we are in a onChange function).