Add dialog to copy various types of links for a claim. #4474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinite-persistence
force-pushed
the
#4293_Better_download_link_support
branch
from
fc8c569
to
c7bbe36
Compare
|
Cool! I wonder if this should just be integrated with the Share modal. I'll give your PR's a closer look on Monday. Have a good weekend! |
|
True, the new one is just a stripped-down version of what's already available in |
|
@infinite-persistence lets change the |
|
The file-download link already exists in the Share Modal, so I only changed the icon. I used the chain (link) icon as I think it makes more sense than the clipboard (can change if you disagree).
|
infinite-persistence
force-pushed
the
#4293_Better_download_link_support
branch
from
c7bbe36
to
4585be1
Compare
## Issue Fixes 4293 `Better download link support` - [x] make it so you can right click a download button > copy download URL Given that this could be useful in mobile/web as well, I used a button+modal instead of the right-click approach. - [ ] in share dialog, show download URL to copy for non-video content This is already implemented, albeit hidden in the "More..." expansion.
…download link. This reverts commit cb47ed6.
|
Rebasing to latest master to resolve changelog conflict: |
infinite-persistence
force-pushed
the
#4293_Better_download_link_support
branch
from
4585be1
to
0a851fb
Compare
|
Nice. I like the chain icon more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4293
Better download link supportmake it so you can right click a download button > copy download URL
Given that this could be useful in mobile/web as well, I used a button/modal instead of the right-click approach.
in share dialog, show download URL to copy for non-video content
This is already implemented, albeit hidden in the "More..." expansion.