-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-app text and markdown publishing #4436
Conversation
Waiting for:
|
I WAS ON VACATION SO I AM LATE TO EXPRESS MY EXCITEMENT HOPEFULLY ALL CAPITAL LETTERS MAKES UP FOR IT |
@btzr-io I merged your lbry-redux pr. You can point the desktop at 85f0f574bd082ca5d0b87dcba11863fb3f050555 |
@btzr-io are you unblocked on this? |
@kauffj yeah, I'm still experimenting on some things, cant push changes yet |
Added a save dialog so the user can choose where to save the new "story" as a markdown or text file. Almost there, somethings left to do:
|
Looks like my machine ( windows 10 ) don't have any registration of the Is there a better way to handle this ? |
make publishing story work on the web fix file not loading when missing content type
Now publishing a "story" should also work on web, I'm still not sure how to handle the editing part. On desktop I can just rewrite the original file if a change is made, I guess on Also If the user removes the file from desktop, will this be handled in a similar way ? |
I'm not sure of a better way to do that, but since this is only for markdown files, I think just checking the content type should be ok. I think you will need to use the streaming url web, to get the streaming URL, you need to call
I'm not sure what that means. Aren't these just temporary files? I didn't think the user would see them. |
@btzr-io How is this going? Anything I can help with? |
@seanyesmunt Almost done, a few flow warnings / errors I need to fix, I'll let you know if I have more questions |
I'll reopen a new one 😛 |
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number:
What is the current behavior?
What is the new behavior?
Other information