Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support drag-and-drop file publishing #4170

Merged
merged 14 commits into from
May 25, 2020
Merged

Support drag-and-drop file publishing #4170

merged 14 commits into from
May 25, 2020

Conversation

btzr-io
Copy link
Collaborator

@btzr-io btzr-io commented May 11, 2020 •
edited
Loading

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

What is the current behavior?

What is the new behavior?

Todo

  • Reduce fileDrop complexity.
  • Smooth transition to publish page
  • Add option to cancel publish navigation.
  • Use a modal for the file selector.
  • Rewrite file selection flow on publish page.

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 11, 2020

@seanyesmunt What do you think? lbryio/lbry-redux#314

@btzr-io

This comment has been minimized.

Sign in to view
@btzr-io btzr-io marked this pull request as ready for review May 15, 2020 05:13
@btzr-io
Copy link
Collaborator Author

btzr-io commented May 15, 2020

I think is ready for a review, before I continue to work on this.

@neb-b
Copy link

neb-b commented May 15, 2020

Great. Will give this a test/review today!

neb-b
neb-b suggested changes May 15, 2020
View reviewed changes
Copy link

@neb-b neb-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. It seems to work good and feels super smooth. I just have one comment on the radio styles

ui/component/common/file-list.jsx Show resolved Hide resolved
ui/component/fileDrop/view.jsx
}, [history]);

// Delay hide and navigation for a smooth transition
const hideDropArea = () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels really smooth 👍

ui/component/fileDrop/view.jsx Outdated Show resolved Hide resolved
@lbry-bot lbry-bot assigned neb-b and unassigned neb-b May 15, 2020
@btzr-io btzr-io mentioned this pull request May 15, 2020
Closed
@btzr-io btzr-io requested a review from neb-b May 17, 2020 23:19
@lbry-bot lbry-bot assigned neb-b and unassigned neb-b May 17, 2020
@btzr-io
Copy link
Collaborator Author

btzr-io commented May 17, 2020 •
edited
Loading

Should I limit the drop area to the card ?

Right now it works if you drop on any place in the window. Maybe change the message to "Drop anywhere..." ?

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 18, 2020 •
edited
Loading

I didn't like the new look when dropping one file and also it didn't make sense to have a radio input just for one choice, so I made it more simple. let me know what you think.

@neb-b
Copy link

neb-b commented May 18, 2020

@btzr-io I just tried running this branch again and nothing happened when I dropped a file on the page.

I think dropping should work for the entire window, not just the card.

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 18, 2020 •
edited
Loading

@seanyesmunt is working for me, what file did you use ? any errors ? 🙃

Can you try a different file ?

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 19, 2020 •
edited
Loading

Also keep in mind folders are not scanned recursively.

@neb-b
Copy link

neb-b commented May 19, 2020

Sorry for the wait. Busy working with paid content on lbry.tv.

Testing again

@neb-b
Copy link

neb-b commented May 19, 2020

Hm it is working for me now! I like the simplified look. Will give this another code review after I merge the big paid content PR!

@neb-b neb-b merged commit ca4bbf5 into master May 25, 2020
@neb-b neb-b deleted the drag-drop branch May 25, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neb-b neb-b neb-b approved these changes

Assignees

@neb-b neb-b

Labels
community PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btzr-io @neb-b