Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tooltip to share, block, and follow buttons. #4090

Merged

Conversation

calvincodes
Copy link
Contributor

PR Checklist

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe: Improvement

Fixes

Issue Number: #4085

What is the current behavior?

No tooltip displayed for share, follow/unfollow, block/unblock buttons.

What is the new behavior?

Tooltip is now displayed for share, follow/unfollow, block/unblock buttons.

tooltip

Other information

@calvincodes
Copy link
Contributor Author

I am not sure which section of CHANGELOG to modify for this one: fix/change/addition.

Copy link
Contributor

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neb-b
Copy link

neb-b commented Apr 28, 2020

Nice work @calvincodes! And thanks again @harshkhandeparkar for creating this issue!

@neb-b neb-b merged commit acefad2 into lbryio:master Apr 28, 2020
@harshkhandeparkar
Copy link
Contributor

@calvincodes you can look at the help wanted issues if you want to help us further.

@calvincodes calvincodes deleted the aj.adding.tooltips.to.channel.action.buttons branch April 28, 2020 18:02
@calvincodes
Copy link
Contributor Author

Thanks @seanyesmunt @harshkhandeparkar. Sure, will check out more issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants