Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use txo list for wallet page: #3979

Merged
merged 4 commits into from
Apr 15, 2020
Merged

use txo list for wallet page: #3979

merged 4 commits into from
Apr 15, 2020

Conversation

jessopb
Copy link
Member

@jessopb jessopb commented Apr 10, 2020

paginated
enable revoking
filtering
separate txo list from transaction list

@jessopb jessopb requested a review from neb-b April 10, 2020 17:41
@lbry-bot lbry-bot assigned neb-b and unassigned jessopb Apr 10, 2020
Copy link

@neb-b neb-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor stuff. A few comments.

ui/constants/txo_list.js Outdated Show resolved Hide resolved
ui/component/txoList/view.jsx Outdated Show resolved Hide resolved
ui/component/txoList/view.jsx Show resolved Hide resolved
ui/component/txoList/view.jsx Show resolved Hide resolved
ui/component/txoList/view.jsx Outdated Show resolved Hide resolved
ui/component/transactionListTable/view.jsx Outdated Show resolved Hide resolved
ui/component/transactionListTable/view.jsx Outdated Show resolved Hide resolved
ui/component/txoList/view.jsx Show resolved Hide resolved
ui/component/common/card.jsx Outdated Show resolved Hide resolved
@lbry-bot lbry-bot assigned jessopb and unassigned neb-b Apr 10, 2020
ui/component/common/card.jsx Outdated Show resolved Hide resolved
ui/component/transactionListTable/view.jsx Outdated Show resolved Hide resolved
ui/constants/txo_list.js Outdated Show resolved Hide resolved
ui/component/txoList/view.jsx Show resolved Hide resolved
ui/component/txoList/view.jsx Show resolved Hide resolved
ui/component/txoList/view.jsx Outdated Show resolved Hide resolved
@lbry-bot lbry-bot assigned jessopb and unassigned jessopb Apr 10, 2020
@lbry-bot lbry-bot assigned jessopb and unassigned jessopb Apr 13, 2020
@jessopb jessopb requested a review from kauffj April 13, 2020 17:29
@lbry-bot lbry-bot assigned kauffj and unassigned jessopb Apr 13, 2020
@jessopb jessopb requested a review from neb-b April 13, 2020 17:29
paginated
enable revoking
filtering

txo pagination changes

move constants

remove fetchTransactions() calls

review changes

final changes
ui/component/common/card.jsx Outdated Show resolved Hide resolved
ui/component/router/view.jsx Outdated Show resolved Hide resolved
ui/component/txoList/view.jsx Outdated Show resolved Hide resolved
ui/component/txoList/view.jsx Outdated Show resolved Hide resolved
@jessopb jessopb force-pushed the feat--txo-list-paginated branch 2 times, most recently from 3b34608 to a68a161 Compare April 15, 2020 14:28
@neb-b neb-b merged commit 24eb0c2 into master Apr 15, 2020
@neb-b neb-b deleted the feat--txo-list-paginated branch April 15, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants