got frustrated about no claim id on channels and went wild #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kauffj
force-pushed
the
about_page_cleanup
branch
from
458ac0f
to
4ad981f
Compare
|
@seanyesmunt @tzarebczan wanted total publishes displayed and this was an easy place to put it I'm in favor of putting this somewhere else when there's time to be more thoughtful about it though |
|
I think it makes sense to put it there, at least for now. Checking it out |
neb-b
reviewed
Mar 12, 2020
| label={__('view all claims', { | ||
| normalized_uri: uri, | ||
| })} | ||
| navigate={`/$/${PAGES.TOP}?name=${claim.name}`} |
There was a problem hiding this comment.
I don't think this link does what you want. It shows all claims for that claim name, which will just be other channels with the same name?
http://lbry.tv/$/top?name=@kauffj
kauffj
force-pushed
the
about_page_cleanup
branch
from
920ed12
to
c2468d3
Compare
kauffj
force-pushed
the
about_page_cleanup
branch
from
c2468d3
to
a5e2cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.