Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download all transactions in CSV #3692

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

Lukewh
Copy link
Contributor

@Lukewh Lukewh commented Feb 14, 2020

PR Checklist

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

What is the current behavior?

Currently exporting your transactions only exports the filtered list of transactions, or the first page.

What is the new behavior?

All transactions are downloaded - ignoring any filtering.

Other information

The breaking change here is that the export button exports all transactions, the previous functionality of filtering may be desired by some people.
I feel, however, that most people will want to download the whole data set and filter it themselves in an external program.

@neb-b
Copy link

neb-b commented Feb 14, 2020

Nice find! We are just about to release a new app. I'll merge this right after that is done (probably later today).

@neb-b neb-b merged commit 9a5c2cd into lbryio:master Feb 14, 2020
@tzarebczan
Copy link
Contributor

Thanks for the PR @Lukewh ! Can we show you some appreciation for the contribution?

@kauffj
Copy link
Member

kauffj commented Feb 20, 2020

Just also chiming in to say thanks @Lukewh. Many fans and users of Canonical here at LBRY 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants