Feat new referrals #3462
Feat new referrals #3462
Conversation
jessopb
force-pushed
the
feat-newReferrals
branch
from
4d58a02
to
42a95e3
Compare
| /> | ||
| </Form> | ||
| <div className="card__actions"> | ||
| <Button button="primary" label={__('Done')} onClick={closeModal} /> |
There was a problem hiding this comment.
I think this could just be the form submit button and it would eliminate an entire button from the modal
| </Form> | ||
| <div className="card__actions"> | ||
| <Button button="primary" label={__('Done')} onClick={closeModal} /> | ||
| <Button button="link" label={__('Close')} onClick={closeModal} /> |
There was a problem hiding this comment.
I renamed this from cancel to close. Be careful with labeling things cancel if it doesn't actually undo things (or prevent submission of unsaved values).
|
|
||
| return ( | ||
| <Card | ||
| title={__(`Welcome!`)} |
There was a problem hiding this comment.
@seanyesmunt I told @jessopb it was out of scope for his work so not to worry about it, but I think this step is probably the weakest part of the new onboarding/invite system. A brand new user has clicked a link a friend sent them, gone through account creation and email confirmation, and then is kind of just... dumped on the home page (which for now is just them following a single channel).
This doesn't need to be worked out before RC, but it would be good to consider the homepage UX for this case (brand new user following one channel that may be empty or not have much in it)
enable visiting /$/CODE or /$/invite/CHANNEL enable visiting /ANY?=[CODE|CHANNEL] to set and claim enable /$/invite selecting channels for referral codes add ?r=CODE to share modal enable setting referrer and claiming reward from rewards page
bump lbryinc improve invite states register channels with apis fix duplicate subscriptions
refactor invited page check if subscribed first always follow regardless of reward status
neb-b
force-pushed
the
feat-newReferrals
branch
from
bc6a6a5
to
9af2dca
Compare
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number:
What is the current behavior?
What is the new behavior?
Other information