autoLaunch on startup #3236
Merged
autoLaunch on startup #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
neb-b
reviewed
Nov 18, 2019
| }); | ||
|
|
||
| window.webContents.once('dom-ready', () => { | ||
| startMinimized && window.hide() |
There was a problem hiding this comment.
Is this needed? I would imagine once the dom-ready event is fired the window should already be hidden.
There was a problem hiding this comment.
It seemed like this is the one that makes it work on windows -reliably-.
There was a problem hiding this comment.
Should this line be just removed https://github.com/lbryio/lbry-desktop/pull/3236/files#diff-dd110088e25f2da03c36e833bd1295a8R131
And placed here instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.