Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less intrusive first run experience #2210

Merged
merged 3 commits into from
Jan 25, 2019
Merged

Less intrusive first run experience #2210

merged 3 commits into from
Jan 25, 2019

Conversation

neb-b
Copy link

@neb-b neb-b commented Jan 18, 2019 •
edited
Loading

Changes

  • Removing first run modals for inline elements.
    • ModalEmailCollection => FirstRunEmailCollection
  • Add yrbl to first run
  • Hard code settings in reducer
  • Default to dark mode

@neb-b neb-b force-pushed the first-run branch 2 times, most recently from 2fc689f to b9a22ba Compare January 22, 2019 18:30
neb-b
neb-b commented Jan 22, 2019
View reviewed changes
src/renderer/redux/reducers/settings.js
[SETTINGS.FIRST_RUN_COMPLETED]: getLocalStorageSetting(SETTINGS.FIRST_RUN_COMPLETED, false),
[SETTINGS.CREDIT_REQUIRED_ACKNOWLEDGED]: false, // this needs to be re-acknowledged every run
[SETTINGS.LANGUAGE]: getLocalStorageSetting(SETTINGS.LANGUAGE, 'en'),
[SETTINGS.THEME]: getLocalStorageSetting(SETTINGS.THEME, 'dark'),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tzarebczan 😏

@neb-b neb-b requested a review from skhameneh January 22, 2019 18:35
@lbry-bot lbry-bot assigned skhameneh and unassigned neb-b Jan 22, 2019
@neb-b neb-b changed the title [WIP] Less intrusive first run experience Less intrusive first run experience Jan 22, 2019
@neb-b neb-b mentioned this pull request Jan 24, 2019
Merged
@lbry-bot lbry-bot assigned neb-b and unassigned skhameneh Jan 25, 2019
@neb-b neb-b merged commit 8c0608b into master Jan 25, 2019
@neb-b neb-b deleted the first-run branch January 25, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhameneh skhameneh skhameneh approved these changes

Assignees

@neb-b neb-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neb-b @skhameneh