Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newnew #2144

Merged
merged 8 commits into from
Dec 19, 2018
Merged

Newnew #2144

merged 8 commits into from
Dec 19, 2018

Conversation

neb-b
Copy link

@neb-b neb-b commented Dec 12, 2018

Created a new PR for #2102 because that had so many comments.

PR Checklist

  • This PR introduces breaking changes and I have provided a detailed explanation below.

PR Type

What kind of change does this PR introduce?

  • Breaking changes (bugfix or feature that introduces breaking changes)
  • Refactoring (no functional changes)

Fixes

I borked #2053 while attempting to have a sane rebase. This PR refactors the CSS and makes semantic changes in the rendered HTML.

Closes #1976.

What is the current behavior?

Nothing the average user would notice, aside from styling.

What is the new behavior?

New hotness. Sass is (more) organized and easier to manage. It still isn't perfect but it's close.

Copy link
Author

@neb-b neb-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be starting to dislike me, but some more comments.

I think these are mostly minor alignment/consistency issues. The code is looking way better (re media-tile media-card).

I think the biggest outstanding issue is the icons not using the Icon component.

I know there will always be stuff that can be fixed so I don't want to have this sit in review forever. I think we can merge this after these issues are addressed then fix any other stuff individually.

src/renderer/component/common/lbc-symbol.jsx Outdated Show resolved Hide resolved
src/renderer/component/categoryList/view.jsx Show resolved Hide resolved
src/renderer/component/categoryList/view.jsx Show resolved Hide resolved
src/renderer/component/rewardTile/view.jsx Show resolved Hide resolved
src/renderer/component/sideBar/view.jsx Show resolved Hide resolved
src/renderer/scss/init/_gui.scss Show resolved Hide resolved
src/renderer/page/search/view.jsx Show resolved Hide resolved
src/renderer/component/categoryList/view.jsx Show resolved Hide resolved
src/renderer/component/channelTile/view.jsx Outdated Show resolved Hide resolved
src/renderer/page/file/view.jsx Show resolved Hide resolved
@neb-b neb-b merged commit 88befcc into master Dec 19, 2018
@skhameneh skhameneh deleted the newnew branch April 2, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App frontpage redesign
2 participants