Comments support button #2095
Merged
Comments support button #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
commented
Nov 7, 2018
| @@ -36,6 +37,7 @@ export const SKIP_UPGRADE = 'SKIP_UPGRADE'; | |||
| export const START_UPGRADE = 'START_UPGRADE'; | |||
| export const AUTO_UPDATE_DECLINED = 'AUTO_UPDATE_DECLINED'; | |||
| export const AUTO_UPDATE_DOWNLOADED = 'AUTO_UPDATE_DOWNLOADED'; | |||
| export const CLEAR_UPGRADE_TIMER = 'CLEAR_UPGRADE_TIMER'; | |||
There was a problem hiding this comment.
This was added to the lbry-redux action types but it should have never been there. I will do some cleanup in the future to make sure we aren't keeping types there that only belong in the app
skhameneh
approved these changes
Nov 14, 2018
| import { connect } from 'react-redux'; | ||
| import Expandable from './view'; | ||
|
|
||
| export default connect( |
| constructor() { | ||
| super(); | ||
|
|
||
| this.state = { |
There was a problem hiding this comment.
Can also do:
class MyComponent extends PureComponent {
state = {};
}
and use arrow fn's or bind syntax https://babeljs.io/blog/2015/05/14/function-bind
| {description && ( | ||
| <React.Fragment> | ||
| <div className="card__subtext-title">About</div> | ||
| const mediaType = contentType || 'unknown'; |
There was a problem hiding this comment.
Should 'unknown' be a shared constant?
There was a problem hiding this comment.
Probably. Although I'm not sure where else it's used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
<Expandable>componentStill deciding on the copy for button/message